subculture-collective/galdr
1
0
Fork 0
Code Issues 85 Pull Requests Actions Packages Projects Releases Wiki Activity

auth fix again? #258

Merged
onnwee merged 1 commits from uplink/prod into main 2026-02-25 22:02:48 -06:00
Conversation 1 Commits 1 Files Changed 2 +2898 -2
onnwee commented 2026-02-25 22:02:42 -06:00 (Migrated from github.com)
Copy Link
No description provided.
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2026-02-25 22:04:14 -06:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy Link

Pull request overview

This PR adjusts user lookup queries to safely handle nullable profile fields when loading users for authentication and related flows.

Changes:

  • Update users SELECTs in GetByEmail and GetByID to COALESCE(first_name, '') and COALESCE(last_name, '').
  • Minor formatting of the SELECT column list for readability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull request overview This PR adjusts user lookup queries to safely handle nullable profile fields when loading users for authentication and related flows. **Changes:** - Update `users` SELECTs in `GetByEmail` and `GetByID` to `COALESCE(first_name, '')` and `COALESCE(last_name, '')`. - Minor formatting of the SELECT column list for readability. --- 💡 <a href="/subculture-collective/pulse-score/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.
Sign in to join this conversation.
Reviewers
No Reviewers
copilot-pull-request-reviewer[bot]
Labels
Clear labels
area:backend
Go backend/API work
 area:docs
Documentation
 area:frontend
React/TypeScript frontend work
 area:infra
Infrastructure, CI/CD, deployment
 area:integration
Third-party API integrations
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 phase:defensibility
Phase 3: Defensibility (Months 18+)
 phase:expansion
Phase 2: Expansion (Months 6-18)
 phase:mvp
Phase 1: MVP (Weeks 1-6)
 priority:critical
Must be done first, blocks everything
 priority:high
Important, should be done soon
 priority:low
Nice to have, can wait
 priority:medium
Normal priority
 question
Further information is requested
 type:epic
Epic: parent issue grouping related tasks
 type:task
Task: individual implementable work item
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
onnwee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: subculture-collective/galdr#258
Delete Branch "uplink/prod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?